Reduce size of slow testcase in std.algorithm.setops#6280
Reduce size of slow testcase in std.algorithm.setops#6280dlang-bot merged 1 commit intodlang:masterfrom
Conversation
|
Thanks for your pull request and interest in making D better, @FeepingCreature! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
| assert(canFind(N4, tuple(1, 2, 3, 4))); | ||
| assert(canFind(N4, tuple(4, 3, 2, 1))); | ||
| assert(canFind(N4, tuple(10, 31, 7, 12))); | ||
| assert(canFind(N4, tuple(10, 3, 7, 2))); |
There was a problem hiding this comment.
Even better could that line be removed outright? Does it cover anything not already tested by
assert(canFind(N4, tuple(1, 2, 3, 4)));
assert(canFind(N4, tuple(4, 3, 2, 1)));?
There was a problem hiding this comment.
I guess "larger numbers than 1 in every dimension"?
|
Though, BTW, a more fundamental problem here is how variadic |
This test takes an unfeasibly large amount of time to run. (I've never managed to run it to completion.)
The only reason why it appears to pass is that it completes instantly, because canFind never evaluates the Cartesian range at all due to DMD bug #12486. When I fixed it in DMD PR dlang/dmd#8013, the test started timing out.
By the way, how do I get reviewers for that DMD PR?